Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter sub multiplexing #1048

Merged
merged 32 commits into from
May 15, 2024
Merged

feat: filter sub multiplexing #1048

merged 32 commits into from
May 15, 2024

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Mar 11, 2024 •
edited by chaitanyaprem
Loading

As part of status-im/status-go#4665, Filter Management complexities are being moved within go-waku. This is part of larger reliability for req-resp protocols milestone.

This PR captures mainly following:

  1. Moving Filter management logic and wrapping it in an easy to use API by status-go.
  2. subscription channels returned to status-go have to be multiplexed in case of multiple peers. There should be a 1-to-1 mapping between filters and subscriptions in status-go.

Note that rest of the items would be take up in a separate PR such as optimizing filter-ping and Filter peer connectivity maintenance.

@vitvly vitvly self-assigned this Mar 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

Thank you for opening this pull request!

We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted.

Details:

According to the conventional-commits specification, some of the commit messages are not valid.

@status-im-auto
Copy link

status-im-auto commented Mar 11, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 682410e #1 2024-03-11 11:29:24 ~1 min nix-flake 📄log
✔️ 5e61d2b #2 2024-03-11 11:35:08 ~2 min nix-flake 📄log
✔️ b3eadd4 #3 2024-03-11 11:42:51 ~1 min nix-flake 📄log
✔️ f8b4c56 #4 2024-03-16 11:09:03 ~1 min nix-flake 📄log
✖️ e097efe #5 2024-03-28 09:01:58 ~1 min nix-flake 📄log
✖️ 883a58c #6 2024-03-28 09:02:57 ~51 sec nix-flake 📄log
✖️ 295b509 #7 2024-03-28 09:32:03 ~52 sec nix-flake 📄log
✔️ 70f2d34 #8 2024-04-08 16:24:30 ~1 min nix-flake 📄log
✔️ d57c9a3 #9 2024-04-19 12:43:05 ~1 min nix-flake 📄log
✔️ 194bd7f #10 2024-04-26 09:36:17 ~4 min nix-flake 📄log
✔️ 2746040 #11 2024-05-06 09:25:43 ~2 min nix-flake 📄log
✔️ 89b0989 #12 2024-05-06 11:19:55 ~2 min nix-flake 📄log
✔️ dfb5231 #13 2024-05-08 07:03:37 ~3 min nix-flake 📄log
✔️ 632f5b0 #14 2024-05-10 09:41:31 ~1 min nix-flake 📄log
✔️ f0b7b01 #15 2024-05-10 09:58:31 ~2 min nix-flake 📄log
✔️ 07fcb77 #16 2024-05-10 10:16:36 ~1 min nix-flake 📄log
✔️ d0f3a10 #17 2024-05-10 10:49:57 ~1 min nix-flake 📄log
✔️ 9ba0298 #18 2024-05-10 11:08:53 ~1 min nix-flake 📄log
✔️ bafbc2f #19 2024-05-10 11:14:22 ~1 min nix-flake 📄log
✔️ f74d74f #20 2024-05-10 11:23:23 ~1 min nix-flake 📄log
✔️ e581e42 #21 2024-05-10 11:47:12 ~1 min nix-flake 📄log
✔️ 9e20c16 #22 2024-05-10 11:55:03 ~2 min nix-flake 📄log
✔️ e6da6d8 #23 2024-05-13 09:27:53 ~2 min nix-flake 📄log
✔️ 736598c #24 2024-05-14 05:57:58 ~2 min nix-flake 📄log
✔️ 6d89d0d #25 2024-05-14 06:44:33 ~1 min nix-flake 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 36ac57f #26 2024-05-15 06:06:56 ~1 min nix-flake 📄log
✔️ f6c9810 #27 2024-05-15 06:50:21 ~2 min nix-flake 📄log

@vitvly vitvly force-pushed the feat/sub-multiplex branch 2 times, most recently from 5e61d2b to b3eadd4 Compare March 11, 2024 11:40
@vitvly vitvly force-pushed the feat/sub-multiplex branch 2 times, most recently from e097efe to 883a58c Compare March 28, 2024 09:00
@chaitanyaprem chaitanyaprem self-assigned this May 6, 2024
@chaitanyaprem chaitanyaprem changed the title Feat: filter sub multiplexing feat: filter sub multiplexing May 6, 2024
chaitanyaprem
chaitanyaprem reviewed May 7, 2024
View reviewed changes
waku/v2/api/filter.go Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem mentioned this pull request May 13, 2024
Closed
@chaitanyaprem chaitanyaprem marked this pull request as ready for review May 13, 2024 04:52
@chaitanyaprem
Copy link
Collaborator

Note that i am not fixing the conventional commits CI error for now, rather while merging it to master..committs will be squashed and i will fix commit messages then :)

@chaitanyaprem chaitanyaprem mentioned this pull request May 13, 2024
Merged
kaichaosun
kaichaosun reviewed May 13, 2024
View reviewed changes
waku/v2/api/filter.go Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Show resolved Hide resolved
kaichaosun
kaichaosun reviewed May 14, 2024
View reviewed changes
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
richard-ramos
richard-ramos approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

waku/v2/protocol/filter/server.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Show resolved Hide resolved
waku/v2/api/filter.go Show resolved Hide resolved
waku/v2/api/filter.go Outdated Show resolved Hide resolved
waku/v2/api/filter.go Show resolved Hide resolved
@chaitanyaprem chaitanyaprem merged commit 6e47bd1 into master May 15, 2024
10 of 12 checks passed
@chaitanyaprem chaitanyaprem deleted the feat/sub-multiplex branch May 15, 2024 07:34
@chaitanyaprem chaitanyaprem mentioned this pull request May 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem left review comments

@kaichaosun kaichaosun kaichaosun approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

@plopezlpz plopezlpz Awaiting requested review from plopezlpz

Assignees

@chaitanyaprem chaitanyaprem

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitvly @status-im-auto @chaitanyaprem @richard-ramos @kaichaosun